| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Alexey Kondratov <a(dot)kondratov(at)postgrespro(dot)ru> |
| Cc: | Justin Pryzby <pryzby(at)telsasoft(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Masahiko Sawada <masahiko(dot)sawada(at)2ndquadrant(dot)com>, Steve Singer <steve(at)ssinger(dot)info>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Robert Haas <robertmhaas(at)gmail(dot)com>, Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Jose Luis Tallon <jltallon(at)adv-solutions(dot)net> |
| Subject: | Re: Allow CLUSTER, VACUUM FULL and REINDEX to change tablespace on the fly |
| Date: | 2021-01-13 08:22:49 |
| Message-ID: | X/6t2V7ynK7dv2X+@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Dec 23, 2020 at 07:30:35PM +0300, Alexey Kondratov wrote:
> After eyeballing the patch I can add that we should alter this comment:
>
> int options; /* bitmask of VacuumOption */
>
> as you are going to replace VacuumOption with VACOPT_* defs. So this should
> say:
>
> /* bitmask of VACOPT_* */
Check.
>
> Also I have found naming to be a bit inconsistent:
> * we have ReindexOptions, but VacuumParams
> * and ReindexOptions->flags, but VacuumParams->options
Check. As ReindexOptions and ClusterOptions are the new members of
the family here, we could change them to use Params instead with
"options" as bits32 internally.
> And the last one, you have used bits32 for Cluster/ReindexOptions, but left
> VacuumParams->options as int. Maybe we should also change it to bits32 for
> consistency?
Yeah, that makes sense. I'll send an updated patch based on that.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2021-01-13 08:27:37 | Re: Improper use about DatumGetInt32 |
| Previous Message | Kyotaro Horiguchi | 2021-01-13 08:12:55 | Re: Disable WAL logging to speed up data loading |