| From: | Piotr Stefaniak <postgres(at)piotr-stefaniak(dot)me> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pgindent (was Re: [COMMITTERS] pgsql: Preventive maintenance in advance of pgindent run.) |
| Date: | 2017-05-21 19:52:46 |
| Message-ID: | VI1PR03MB1199E65EFAE1C1EE8E02D040F2FB0@VI1PR03MB1199.eurprd03.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
> * const unsigned(*TABLE_index)[2];
> * OffsetNumber(*findChildPtr) (GinBtree, Page, BlockNumber, OffsetNumber);
> * an overlength comment line is simply busted altogether
Fixed and pushed to my github repository. Note that indent won't wrap
long lines like links or paths anymore. But obviously it can't join
parts of long links that have been wrapped by previous pgindent runs.
> * the comments get formatted differently for -ts4 than -ts8
> * extra spacing getting inserted for fairly long labels
> * some enum declarations get the phony extra indentation
> * comments on the same line are now run together
> * surplus indentation for SH_ELEMENT_TYPE * data;
Please tell me if the list of your complaints above is incomplete. I
will analyze those next.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2017-05-21 23:50:14 | Re: pgindent (was Re: [COMMITTERS] pgsql: Preventive maintenance in advance of pgindent run.) |
| Previous Message | Tom Lane | 2017-05-21 17:05:38 | pgsql: Fix precision and rounding issues in money multiplication and di |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Huong Dangminh | 2017-05-21 22:27:36 | Re: [ANNOUNCE] PostgreSQL 10 Beta 1 Released! |
| Previous Message | Rosser Schwarz | 2017-05-21 19:04:22 | Patch: add --if-exists to pg_recvlogical |