| From: | "Takamichi Osumi (Fujitsu)" <osumi(dot)takamichi(at)fujitsu(dot)com> |
|---|---|
| To: | 'Melih Mutlu' <m(dot)melihmutlu(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Euler Taveira <euler(at)eulerto(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, "shiy(dot)fnst(at)fujitsu(dot)com" <shiy(dot)fnst(at)fujitsu(dot)com> |
| Subject: | RE: Allow logical replication to copy tables in binary format |
| Date: | 2023-03-14 15:20:52 |
| Message-ID: | TYWPR01MB8362E67A4E84C765A220E6A8EDBE9@TYWPR01MB8362.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tuesday, March 14, 2023 8:02 PM Melih Mutlu <m(dot)melihmutlu(at)gmail(dot)com> wrote:
> Attached v13.
Hi,
Thanks for sharing v13. Few minor review comments.
(1) create_subscription.sgml
+ column types as opposed to text format. Even when this option is enabled,
+ only data types having binary send and receive functions will be
+ transferred in binary. Note that the initial synchronization requires
(1-1)
I think it's helpful to add a reference for the description about send and receive functions (e.g. to the page of CREATE TYPE).
(1-2)
Also, it would be better to have a cross reference from there to this doc as one paragraph probably in "Notes". I suggested this, because send and receive functions are described as "optional" there and missing them leads to error in the context of binary table synchronization.
(3) copy_table()
+ /*
+ * If the publisher version is earlier than v14, it COPY command doesn't
+ * support the binary option.
+ */
This sentence doesn't look correct grammatically. We can replace "it COPY command" with "subscription" for example. Kindly please fix it.
Best Regards,
Takamichi Osumi
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2023-03-14 15:32:56 | Re: Add LZ4 compression in pg_dump |
| Previous Message | gkokolatos | 2023-03-14 15:18:33 | Re: Add LZ4 compression in pg_dump |