[pgAdmin4][patch] In SharedServersGetTestCase, the prompt information is wrong

From: "zhangjie2(at)fujitsu(dot)com" <zhangjie2(at)fujitsu(dot)com>
To: "pgadmin-hackers(at)lists(dot)postgresql(dot)org" <pgadmin-hackers(at)lists(dot)postgresql(dot)org>
Subject: [pgAdmin4][patch] In SharedServersGetTestCase, the prompt information is wrong
Date: 2021-07-22 07:39:04
Message-ID: TYWPR01MB7678AC09EB538FC37162B1EFF9E49@TYWPR01MB7678.jpnprd01.prod.outlook.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi, all

SharedServersGetTestCase can only be tested in SERVER mode.
So, in Desktop mode, prompt information will be output.
However, the prompt is wrong.
("Can not run shared servers test cases in the SERVER mode.")

I think it should be changed to the following prompt information
"Can not run shared servers test cases in the Desktop mode."

----------------------------------------------------------------------------
file: web\pgadmin\browser\server_groups\servers\tests\test_shared_server.py

SharedServersGetTestCase

def setUp(self):
"""This function add the server to test the GET API"""

if config.SERVER_MODE is False:
self.skipTest(
"Can not run shared servers test cases in the SERVER mode." ※
)
----------------------------------------------------------------------------

Here is a patch for test_shared_server.py
Please review.

Best Regards!
Zhangjie

Attachment Content-Type Size
fix_test_shared_server.patch application/octet-stream 749 bytes

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Nikhil Mohite 2021-07-22 08:16:08 [pgAdmin][RM-6574]: The paste is not working through Right-Click option on PSQL
Previous Message Akshay Joshi 2021-07-22 06:57:07 Re: Bug #6337 Patch