[pgAdmin4][patch] error message is incorrect in domains

From: "zhangjie2(at)fujitsu(dot)com" <zhangjie2(at)fujitsu(dot)com>
To: "pgadmin-hackers(at)lists(dot)postgresql(dot)org" <pgadmin-hackers(at)lists(dot)postgresql(dot)org>
Cc: "zhangjie2(at)fujitsu(dot)com" <zhangjie2(at)fujitsu(dot)com>
Subject: [pgAdmin4][patch] error message is incorrect in domains
Date: 2021-09-27 08:56:48
Message-ID: TYWPR01MB7678393FB87082348AEDA114F9A79@TYWPR01MB7678.jpnprd01.prod.outlook.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi, all

In domains's create function, res is used for all error messages.
I don't think this is correct.
On line 13, doid should be used as the error message.Because the execution result of line 11 is doid.
On line 21, scid should be used as the error message.Because the execution result of line 19 is scid.
There are similar problems in other functions.
Here is a patch for domains.
Please review.

file: pgadmin4\web\pgadmin\browser\server_groups\servers\databases\schemas\domains\__init__.py
----------------------------------------------------------------------------
def create(self, gid, sid, did, scid):
......
1 status, res = self.conn.execute_scalar(SQL)
2 if not status:
3 return internal_server_error(errormsg=res) ※1 res is OK
4
5 # We need oid to add object in tree at browser, below sql will
6 # gives the same
7 SQL = render_template("/".join([self.template_path,
8 self._OID_SQL]),
9 basensp=data['basensp'],
10 name=data['name'])
11 status, doid = self.conn.execute_scalar(SQL)
12 if not status:
13 return internal_server_error(errormsg=res) ※2 res => doid
14
15 # Get updated schema oid
16 SQL = render_template("/".join([self.template_path,
17 self._OID_SQL]),
18 doid=doid)
19 status, scid = self.conn.execute_scalar(SQL)
20 if not status:
21 return internal_server_error(errormsg=res) ※3 res => scid
----------------------------------------------------------------------------------

Attachment Content-Type Size
domains.patch application/octet-stream 2.3 KB

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Akshay Joshi 2021-09-27 10:23:05 pgAdmin 4 commit: Correct the variable names in the error messages for
Previous Message Khushboo Vashi 2021-09-27 08:21:47 Re: [pgAdmin4][Patch] - RM #6129 - Port browser tree to React