| From: | "osumi(dot)takamichi(at)fujitsu(dot)com" <osumi(dot)takamichi(at)fujitsu(dot)com> |
|---|---|
| To: | "shiy(dot)fnst(at)fujitsu(dot)com" <shiy(dot)fnst(at)fujitsu(dot)com>, 'Peter Smith' <smithpb2250(at)gmail(dot)com> |
| Cc: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, "tanghy(dot)fnst(at)fujitsu(dot)com" <tanghy(dot)fnst(at)fujitsu(dot)com>, "wangw(dot)fnst(at)fujitsu(dot)com" <wangw(dot)fnst(at)fujitsu(dot)com>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, "vignesh21(at)gmail(dot)com" <vignesh21(at)gmail(dot)com>, "amit(dot)kapila16(at)gmail(dot)com" <amit(dot)kapila16(at)gmail(dot)com>, "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Greg Nancarrow <gregn4422(at)gmail(dot)com> |
| Subject: | RE: Failed transaction statistics to measure the logical replication progress |
| Date: | 2022-03-03 03:33:41 |
| Message-ID: | TYCPR01MB8373555F1F2DD16A29F039FDED049@TYCPR01MB8373.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wednesday, March 2, 2022 5:29 PM Shi, Yu/侍 雨 <shiy(dot)fnst(at)fujitsu(dot)com> wrote:
> A comments on the v26 patch.
Thank you for checking the patch !
>
> The following document about pg_stat_subscription_stats view only says that
> "showing statistics about errors", should we add something about transactions
> here?
>
> <row>
>
> <entry><structname>pg_stat_subscription_stats</structname><indexterm
> ><primary>pg_stat_subscription_stats</primary></indexterm></entry>
> <entry>One row per subscription, showing statistics about errors.
> See <link linkend="monitoring-pg-stat-subscription-stats">
> <structname>pg_stat_subscription_stats</structname></link> for
> details.
> </entry>
> </row>
>
>
> I noticed that the v24 patch has some changes about the description of this
> view. Maybe we can modify to "showing statistics about errors and
> transactions".
You are right. Fixed.
New patch v27 that incorporated your comments is shared in [1].
Kindly have a look at it.
Best Regards,
Takamichi Osumi
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ajin Cherian | 2022-03-03 03:36:05 | Re: logical replication empty transactions |
| Previous Message | osumi.takamichi@fujitsu.com | 2022-03-03 03:28:19 | RE: Failed transaction statistics to measure the logical replication progress |