| From: | "Takamichi Osumi (Fujitsu)" <osumi(dot)takamichi(at)fujitsu(dot)com> |
|---|---|
| To: | 'Amit Kapila' <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Melih Mutlu <m(dot)melihmutlu(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Euler Taveira <euler(at)eulerto(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, "shiy(dot)fnst(at)fujitsu(dot)com" <shiy(dot)fnst(at)fujitsu(dot)com> |
| Subject: | RE: Allow logical replication to copy tables in binary format |
| Date: | 2023-03-15 06:49:36 |
| Message-ID: | TYCPR01MB8373142DA60F2ADC498BDE97EDBF9@TYCPR01MB8373.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On Wednesday, March 15, 2023 2:34 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> On Tue, Mar 14, 2023 at 8:50 PM Takamichi Osumi (Fujitsu)
> <osumi(dot)takamichi(at)fujitsu(dot)com> wrote:
> >
> > On Tuesday, March 14, 2023 8:02 PM Melih Mutlu
> <m(dot)melihmutlu(at)gmail(dot)com> wrote:
> > (3) copy_table()
> >
> > + /*
> > + * If the publisher version is earlier than v14, it COPY command
> doesn't
> > + * support the binary option.
> > + */
> >
> > This sentence doesn't look correct grammatically. We can replace "it COPY
> command" with "subscription" for example. Kindly please fix it.
> >
>
> How about something like: "The binary option for replication is supported since
> v14."?
Yes, this looks best to me. I agree with this suggestion.
Best Regards,
Takamichi Osumi
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2023-03-15 06:50:12 | Re: Add pg_walinspect function with block info columns |
| Previous Message | Jeff Davis | 2023-03-15 06:47:42 | Re: ICU locale validation / canonicalization |