| From: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
|---|---|
| To: | 'Masahiko Sawada' <sawada(dot)mshk(at)gmail(dot)com>, Shubham Khanna <khannashubham1197(at)gmail(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | RE: Improve eviction algorithm in ReorderBuffer |
| Date: | 2024-02-08 09:33:08 |
| Message-ID: | TYCPR01MB120770098C895866564E29C24F5442@TYCPR01MB12077.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Dear Sawada-san,
Thanks for making v3 patchset. I have also benchmarked the case [1].
Below results are the average of 5th, there are almost the same result
even when median is used for the comparison. On my env, the regression
cannot be seen.
HEAD (1e285a5) HEAD + v3 patches difference
10910.722 ms 10714.540 ms around 1.8%
Also, here are mino comments for v3 set.
01.
bh_nodeidx_entry and ReorderBufferMemTrackState is missing in typedefs.list.
02. ReorderBufferTXNSizeCompare
Should we assert {ta, tb} are not NULL?
Best Regards,
Hayato Kuroda
FUJITSU LIMITED
https://www.fujitsu.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ashutosh Bapat | 2024-02-08 09:46:52 | Re: Question about behavior of deletes with REPLICA IDENTITY NOTHING |
| Previous Message | vignesh C | 2024-02-08 09:25:23 | Re: Race condition in FetchTableStates() breaks synchronization of subscription tables |