From: | Hongxu Ma <interma(at)outlook(dot)com> |
---|---|
To: | Jelte Fennema <postgres(at)jeltef(dot)nl> |
Cc: | "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: PSQL error: total cell count of XXX exceeded |
Date: | 2023-09-12 02:39:55 |
Message-ID: | TYBP286MB03515815935D9F6FA90C5921B4F1A@TYBP286MB0351.JPNP286.PROD.OUTLOOK.COM |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Thank you for your advice, Jelte.
I have refactored my code, please see the attached patch. (and I put it into https://commitfest.postgresql.org/45/ for trace)
Thanks.
________________________________
From: Jelte Fennema <postgres(at)jeltef(dot)nl>
Sent: Monday, September 11, 2023 15:04
To: Hongxu Ma <interma(at)outlook(dot)com>
Cc: David G. Johnston <david(dot)g(dot)johnston(at)gmail(dot)com>; PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: PSQL error: total cell count of XXX exceeded
On Mon, 11 Sept 2023 at 08:51, Hongxu Ma <interma(at)outlook(dot)com> wrote:
>
> I created a patch to fix it.
> Really appreciate to anyone can help to review it.
> Thanks.
I think "product" as a variable name isn't very descriptive. Let's
call it total_cells (or something similar instead).
Other than that I think it's a good change. content->cellsadded is
also a long, So I agree that I don't think the limit of int cells was
intended here.
Attachment | Content-Type | Size |
---|---|---|
v2-0001-Using-long-type-in-printTableAddCell.patch | application/octet-stream | 1.6 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Smith | 2023-09-12 03:07:51 | Re: Add 'worker_type' to pg_stat_subscription |
Previous Message | Zhijie Hou (Fujitsu) | 2023-09-12 02:33:25 | RE: [PoC] pg_upgrade: allow to upgrade publisher node |