| From: | "shiy(dot)fnst(at)fujitsu(dot)com" <shiy(dot)fnst(at)fujitsu(dot)com> |
|---|---|
| To: | vignesh C <vignesh21(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, "kuroda(dot)hayato(at)fujitsu(dot)com" <kuroda(dot)hayato(at)fujitsu(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | RE: Handle infinite recursion in logical replication setup |
| Date: | 2022-06-30 03:47:24 |
| Message-ID: | TYAPR01MB6315ABAE19C44C50E1D30327FDBA9@TYAPR01MB6315.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Jun 28, 2022 2:18 PM vignesh C <vignesh21(at)gmail(dot)com> wrote:
>
> Thanks for the comments, the attached v25 patch has the changes for the
> same.
>
Thanks for updating the patch. Here are some comments.
0002 patch:
==============
1.
+# Test the CREATE SUBSCRIPTION 'origin' parameter and its interaction with
+# 'copy_data' parameter.
It seems we should move "and its interaction with 'copy_data' parameter" to
0003 patch.
0003 patch
==============
1.
When using ALTER SUBSCRIPTION ... REFRESH, subscription will throw an error if
any table is subscribed in publisher, even if the table has been subscribed
before refresh (which won't do the initial copy when refreshing). It looks the
previously subscribed tables don't need this check. Would it be better that we
only check the tables which need to do the initial copy?
2.
+ errmsg("table:%s.%s might have replicated data in the publisher",
+ nspname, relname),
I think the table name needs to be enclosed in double quotes, which is
consistent with other messages.
Regards,
Shi yu
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nikolay Shaplov | 2022-06-30 03:47:48 | Re: [PATCH] minor reloption regression tests improvement |
| Previous Message | Fujii Masao | 2022-06-30 03:28:43 | Backup command and functions can cause assertion failure and segmentation fault |