| From: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
|---|---|
| To: | 'Amit Kapila' <amit(dot)kapila16(at)gmail(dot)com>, "shiy(dot)fnst(at)fujitsu(dot)com" <shiy(dot)fnst(at)fujitsu(dot)com> |
| Cc: | Peter Smith <smithpb2250(at)gmail(dot)com>, Melih Mutlu <m(dot)melihmutlu(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Euler Taveira <euler(at)eulerto(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, "Takamichi Osumi (Fujitsu)" <osumi(dot)takamichi(at)fujitsu(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | RE: Allow logical replication to copy tables in binary format |
| Date: | 2023-03-22 10:36:47 |
| Message-ID: | TYAPR01MB5866F3B471D04E3EE3941765F5869@TYAPR01MB5866.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Dear Amit, hackers,
> The patch looks mostly good to me. However, I have one
> question/comment as follows:
>
> - <varlistentry>
> + <varlistentry id="sql-createsubscription-binary" xreflabel="binary">
> <term><literal>binary</literal> (<type>boolean</type>)</term>
> <listitem>
>
> To allow references to the binary option, we add the varlistentry id
> here. It looks slightly odd to me to add id for just one entry, see
> commit 78ee60ed84bb3a1cf0b6bd9a715dcbcf252a90f5 where we have
> purposefully added ids to allow future references. Shall we add id to
> other options as well on this page?
I have analyzed same points and made patch that could be applied atop v19-0001.
Please check 0002 patch.
Best Regards,
Hayato Kuroda
FUJITSU LIMITED
| Attachment | Content-Type | Size |
|---|---|---|
| v19-0001-Allow-logical-replication-to-copy-table-in-binary.patch | application/octet-stream | 15.5 KB |
| v19-0002-Add-XML-ID-attributes-to-create_subscription.sgm.patch | application/octet-stream | 7.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kumar, Sachin | 2023-03-22 10:55:33 | RE: Initial Schema Sync for Logical Replication |
| Previous Message | Daniel Gustafsson | 2023-03-22 10:22:44 | Re: Commitfest 2023-03 starting tomorrow! |