| From: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
|---|---|
| To: | 'Kyotaro Horiguchi' <horikyota(dot)ntt(at)gmail(dot)com> |
| Cc: | "michael(at)paquier(dot)xyz" <michael(at)paquier(dot)xyz>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | RE: pg_ctl start may return 0 even if the postmaster has been already started on Windows |
| Date: | 2023-09-22 12:20:56 |
| Message-ID: | TYAPR01MB5866ECADBBB02845504E7A7FF5FFA@TYAPR01MB5866.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Dear Horiguchi-san,
Thank you for making a patch! They can pass ci.
I'm still not sure what should be, but I can respond a part.
> Another issue is.. that I haven't been able to cause the false
> positive of pg_ctl start.. Do you have a concise reproducer of the
> issue?
I found a short sleep in pg_ctl/t/001_start_stop.pl. This was introduced in
6bcce2580 to ensure waiting more than 2 seconds. I've tested on my CI and
found that removing the sleep can trigger the failure. Also, I confirmed your patch
fixes the problem. PSA the small patch for cfbot. 0001 and 0002 were not changed.
Best Regards,
Hayato Kuroda
FUJITSU LIMITED
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Disable-autoruns-for-cmd.exe-on-Windows.patch | application/octet-stream | 1.3 KB |
| v2-0002-Improve-pg_ctl-postmaster-process-check-on-Window.patch | application/octet-stream | 5.1 KB |
| v2-0003-Remove-short-sleep-from-001_start_stop.pl.patch | application/octet-stream | 1.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Drouvot, Bertrand | 2023-09-22 12:30:59 | Re: Synchronizing slots from primary to standby |
| Previous Message | Daniel Gustafsson | 2023-09-22 11:52:26 | Re: Refactor ssl tests to avoid using internal PostgreSQL::Test::Cluster methods |