| From: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
|---|---|
| To: | "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com> |
| Cc: | Peter Smith <smithpb2250(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Bruce Momjian <bruce(at)momjian(dot)us>, Julien Rouhaud <rjuju123(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, 'Dilip Kumar' <dilipbalaut(at)gmail(dot)com> |
| Subject: | RE: [PoC] pg_upgrade: allow to upgrade publisher node |
| Date: | 2023-09-12 11:50:35 |
| Message-ID: | TYAPR01MB5866EAB2E32E697A5AF9DE25F5F1A@TYAPR01MB5866.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Dear Hou,
Thank you for reviewing!
> 1.
>
> #include "access/transam.h"
> #include "catalog/pg_language_d.h"
> +#include "fe_utils/string_utils.h"
> #include "pg_upgrade.h"
>
> It seems we don't need this head file anymore.
Removed.
> 2.
> + if (*invalidated && SlotIsLogical(s) && IsBinaryUpgrade)
> + elog(ERROR, "Replication slots must not be invalidated
> during the upgrade.");
>
> I think normally the first letter is lowercase, and we can avoid the period.
Right, fixed. Also, a period is removed based on the rule. Apart from other detailed
messages, this just reports what happened.
```
if (nslots_on_old > max_replication_slots)
pg_fatal("max_replication_slots (%d) must be greater than or equal to the number of "
- "logical replication slots (%d) on the old cluster.",
+ "logical replication slots (%d) on the old cluster",
max_replication_slots, nslots_on_old);
```
Best Regards,
Hayato Kuroda
FUJITSU LIMITED
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Matthias van de Meent | 2023-09-12 12:25:40 | Re: Detoasting optionally to make Explain-Analyze less misleading |
| Previous Message | Hayato Kuroda (Fujitsu) | 2023-09-12 11:50:30 | RE: [PoC] pg_upgrade: allow to upgrade publisher node |