| From: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
|---|---|
| To: | "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, shveta malik <shveta(dot)malik(at)gmail(dot)com>, "wangw(dot)fnst(at)fujitsu(dot)com" <wangw(dot)fnst(at)fujitsu(dot)com>, "shiy(dot)fnst(at)fujitsu(dot)com" <shiy(dot)fnst(at)fujitsu(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Peter Smith <smithpb2250(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
| Subject: | RE: Perform streaming logical transactions by background workers and parallel apply |
| Date: | 2023-01-26 03:36:57 |
| Message-ID: | TYAPR01MB5866B73F090BA597263AAD08F5CF9@TYAPR01MB5866.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Dear Hou,
Thank you for updating the patch! Followings are comments.
1. config.sgml
```
+ the changes till logical_decoding_work_mem is reached. It can also be
```
I think it should be sandwiched by <varname>.
2. config.sgml
```
+ On the publisher side, <varname>logical_replication_mode</varname> allows
+ allows streaming or serializing changes immediately in logical decoding.
```
Typo "allows allows" -> "allows"
3. test general
You confirmed that the leader started to serialize changes, but did not ensure the endpoint.
IIUC the parallel apply worker exits after applying serialized changes, and it is not tested yet.
Can we add polling the log somewhere?
4. 015_stream.pl
```
+is($result, qq(15000), 'all changes are replayed from file')
```
The statement may be unclear because changes can be also replicated when streaming = on.
How about: "parallel apply worker replayed all changes from file"?
Best Regards,
Hayato Kuroda
FUJITSU LIMITED
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2023-01-26 03:40:06 | Re: Record queryid when auto_explain.log_verbose is on |
| Previous Message | Andres Freund | 2023-01-26 03:10:59 | Re: New strategies for freezing, advancing relfrozenxid early |