| From: | "kuroda(dot)hayato(at)fujitsu(dot)com" <kuroda(dot)hayato(at)fujitsu(dot)com> |
|---|---|
| To: | 'Fujii Masao' <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
| Cc: | "'pgsql-hackers(at)lists(dot)postgresql(dot)org'" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, 'Tom Lane' <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Subject: | RE: Allow escape in application_name (was: [postgres_fdw] add local pid to fallback_application_name) |
| Date: | 2021-09-01 10:04:21 |
| Message-ID: | TYAPR01MB5866B697888D5568E6D1546BF5CD9@TYAPR01MB5866.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Dear Fujii-san,
> Can we split the patch into two as follows? If so, we can review
> and commit them one by one.
>
> #1. Add application_name GUC into postgres_fdw
> #2. Allow to specify special escape characters in application_name that
> postgres_fdw uses.
OK, I split and attached like that. 0001 adds new GUC, and
0002 allows to accept escapes.
> For now I've not found real use case that implementing the feature
> in libpq would introduce. So IMO postgres_fdw version is better.
+1, so I'll focus on the this version.
Best Regards,
Hayato Kuroda
FUJITSU LIMITED
| Attachment | Content-Type | Size |
|---|---|---|
| v05_0002_allow_to_escape.patch | application/octet-stream | 9.9 KB |
| v05_0001_add_application_name_GUC.patch | application/octet-stream | 5.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bharath Rupireddy | 2021-09-01 10:28:44 | Re: Trap errors from streaming child in pg_basebackup to exit early |
| Previous Message | Yugo NAGATA | 2021-09-01 09:33:44 | Re: Fix around conn_duration in pgbench |