Quick Links

RE: [small patch] Change datatype of ParallelMessagePending from "volatile bool" to "volatile sig_atomic_t"

From:	"kuroda(dot)hayato(at)fujitsu(dot)com" <kuroda(dot)hayato(at)fujitsu(dot)com>
To:	'Michael Paquier' <michael(at)paquier(dot)xyz>
Cc:	PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject:	RE: [small patch] Change datatype of ParallelMessagePending from "volatile bool" to "volatile sig_atomic_t"
Date:	2022-09-28 04:47:09
Message-ID:	TYAPR01MB58669A9EC96AA3078C2CD938F5549@TYAPR01MB5866.jpnprd01.prod.outlook.com
Views:	Raw Message \| Whole Thread \| Download mbox \| Resend email
Thread:
Lists:	pgsql-hackers

Dear Michael,

> Yeah, at least as of the cancel callback psql_cancel_callback() that
> handle_sigint() would call on SIGINT as this is set by psql. So it
> does not seem right to use a boolean rather than a sig_atomic_t in
> this case, as well.

PSA fix patch. Note that PromptInterruptContext.enabled was also fixed
because it is substituted from sigint_interrupt_enabled

Best Regards,
Hayato Kuroda
FUJITSU LIMITED

Attachment	Content-Type	Size
0001-Mark-sigint_interrupt_enabled-as-sig_atomic_t.patch	application/octet-stream	2.2 KB

In response to

Re: [small patch] Change datatype of ParallelMessagePending from "volatile bool" to "volatile sig_atomic_t" at 2022-09-28 01:23:11 from Michael Paquier

Responses

Re: [small patch] Change datatype of ParallelMessagePending from "volatile bool" to "volatile sig_atomic_t" at 2022-09-28 07:45:17 from Michael Paquier

Browse pgsql-hackers by date

	From	Date	Subject
Next Message	Tom Lane	2022-09-28 04:49:28	Re: Avoid memory leaks during base backups
Previous Message	Bharath Rupireddy	2022-09-28 04:43:20	Re: Use pg_pwritev_with_retry() instead of write() in dir_open_for_write() to avoid partial writes?