| From: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
|---|---|
| To: | 'Amit Kapila' <amit(dot)kapila16(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Bruce Momjian <bruce(at)momjian(dot)us>, Julien Rouhaud <rjuju123(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com> |
| Subject: | RE: [PoC] pg_upgrade: allow to upgrade publisher node |
| Date: | 2023-09-01 04:47:19 |
| Message-ID: | TYAPR01MB58667BBFEAD84FC997CE5FB2F5E4A@TYAPR01MB5866.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Dear Amit,
Thank you for giving suggestions! I think your fixes are good.
New patch set can be available in [1].
> Apart from this, I have addressed some of the comments raised by you
> for the 0003 patch. Please find the diff patch attached. I think we
> should combine 0002 and 0003 patches.
Yeah, combined.
> I have another comment on the patch:
> + /* Check there are no logical replication slots with a 'lost' state. */
> + res = executeQueryOrDie(conn,
> + "SELECT slot_name FROM pg_catalog.pg_replication_slots "
> + "WHERE wal_status = 'lost' AND "
> + "temporary IS FALSE;");
>
> In this place, shouldn't we explicitly check for slot_type as logical?
> I think we should consistently check for slot_type in all the queries
> used in this patch.
Seems right, the condition was added to all the place.
Best Regards,
Hayato Kuroda
FUJITSU LIMITED
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Langote | 2023-09-01 04:52:15 | Re: remaining sql/json patches |
| Previous Message | Hayato Kuroda (Fujitsu) | 2023-09-01 04:46:18 | RE: [PoC] pg_upgrade: allow to upgrade publisher node |