| From: | "kuroda(dot)hayato(at)fujitsu(dot)com" <kuroda(dot)hayato(at)fujitsu(dot)com> |
|---|---|
| To: | 'Michael Paquier' <michael(at)paquier(dot)xyz> |
| Cc: | "wangsh(dot)fnst(at)fujitsu(dot)com" <wangsh(dot)fnst(at)fujitsu(dot)com>, 'PostgreSQL-development' <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | RE: Refactor ECPGconnect and allow IPv6 connection |
| Date: | 2021-06-21 10:46:18 |
| Message-ID: | TYAPR01MB5866705435593560CA862873F50A9@TYAPR01MB5866.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Dear Michael,
Thank you for replying!
> it does not strike me as a great idea to have a duplicate
> logic doing the parsing of URIs, even if libpq accepts multiple
> hosts/ports as an option.
Yeah, I agree your argument that duplicated parse function should be removed.
ECPG parses connection string because it uses PQconnectdbParams()
even if target is specified in the new-style,
hence my elementary idea is that the paring can be skipped if PQconnectdb() calls.
I will try to remake patches based on the idea.
Best Regards,
Hayato Kuroda
FUJITSU LIMITED
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2021-06-21 10:47:48 | Re: Optionally automatically disable logical replication subscriptions on error |
| Previous Message | Brar Piening | 2021-06-21 10:43:26 | Re: Doc patch for Logical Replication Message Formats (PG14) |