| From: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
|---|---|
| To: | 'Melih Mutlu' <m(dot)melihmutlu(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, "shiy(dot)fnst(at)fujitsu(dot)com" <shiy(dot)fnst(at)fujitsu(dot)com> |
| Cc: | Euler Taveira <euler(at)eulerto(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, "Takamichi Osumi (Fujitsu)" <osumi(dot)takamichi(at)fujitsu(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | RE: Allow logical replication to copy tables in binary format |
| Date: | 2023-03-20 04:13:29 |
| Message-ID: | TYAPR01MB5866657CFB28FFC1D552B97AF5809@TYAPR01MB5866.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Dear Melih,
Thank you for updating the patch.
I checked your added description about initial data sync and I think it's OK.
Few minor comments:
01. copy_table
```
+ List *options = NIL;
```
I found a unnecessary blank just after "List". You can remove it and align definition.
02. copy_table
```
+ options = lappend(options, makeDefElem("format", (Node *) makeString("binary"), -1));
```
The line seems to exceed 80 characters. How do you think to change like following?
```
options = lappend(options,
makeDefElem("format",
(Node *) makeString("binary"), -1));
```
Best Regards,
Hayato Kuroda
FUJITSU LIMITED
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2023-03-20 04:21:38 | Re: Initial Schema Sync for Logical Replication |
| Previous Message | Amit Kapila | 2023-03-20 03:42:30 | Re: logical decoding and replication of sequences, take 2 |