| From: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
|---|---|
| To: | 'Amit Kapila' <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Bruce Momjian <bruce(at)momjian(dot)us>, Julien Rouhaud <rjuju123(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com> |
| Subject: | RE: [PoC] pg_upgrade: allow to upgrade publisher node |
| Date: | 2023-09-11 13:21:47 |
| Message-ID: | TYAPR01MB58665F0B7DDC8DB0FA69D6F3F5F2A@TYAPR01MB5866.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Dear Amit,
Thank you for giving a suggestion!
> >
> > > 2. Why get_old_cluster_logical_slot_infos() need to use
> > > pg_malloc_array whereas for similar stuff get_rel_infos() use
> > > pg_malloc()?
> >
> > They did a same thing. I used pg_malloc_array() macro to keep the code
> > within 80 columns.
> >
>
> I think it is better to be consistent with the existing code in this
> case. Also, see, if the usage in get_loadable_libraries() can also be
> changed back to use pg_malloc().
Fixed as you said. The line becomes too long, so a variable was newly introduced.
Best Regards,
Hayato Kuroda
FUJITSU LIMITED
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Hayato Kuroda (Fujitsu) | 2023-09-11 13:22:01 | RE: [PoC] pg_upgrade: allow to upgrade publisher node |
| Previous Message | Hayato Kuroda (Fujitsu) | 2023-09-11 13:21:39 | RE: [PoC] pg_upgrade: allow to upgrade publisher node |