| From: | "kuroda(dot)hayato(at)fujitsu(dot)com" <kuroda(dot)hayato(at)fujitsu(dot)com> |
|---|---|
| To: | 'Fujii Masao' <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, 'Kyotaro Horiguchi' <horikyota(dot)ntt(at)gmail(dot)com> |
| Cc: | "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>, "ikedamsh(at)oss(dot)nttdata(dot)com" <ikedamsh(at)oss(dot)nttdata(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, "tgl(at)sss(dot)pgh(dot)pa(dot)us" <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Subject: | RE: Allow escape in application_name |
| Date: | 2021-12-17 02:42:25 |
| Message-ID: | TYAPR01MB586659CFEFDD2BD29941987AF5789@TYAPR01MB5866.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Dear Fujii-san,
Sorry I forgot replying your messages.
> >> if (strcmp(keywords[i], "application_name") == 0 &&
> >> values[i] != NULL && *(values[i]) != '\0')
> >
> > I'm not sure but do we have a case that values[i] becomes NULL
> > even if keywords[i] is "application_name"?
>
> No for now, I guess. But isn't it safer to check that, too? I also could not find strong
> reason why that check should be dropped. But you'd like to drop that?
No, I agreed the new checking. I'm just afraid of my code missing.
Best Regards,
Hayato Kuroda
FUJITSU LIMITED
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kyotaro Horiguchi | 2021-12-17 03:06:12 | Re: Allow escape in application_name |
| Previous Message | Greg Stark | 2021-12-17 02:36:37 | Re: WIP: WAL prefetch (another approach) |