| From: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
|---|---|
| To: | 'Amit Kapila' <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | "shiy(dot)fnst(at)fujitsu(dot)com" <shiy(dot)fnst(at)fujitsu(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
| Subject: | RE: Force streaming every change in logical decoding |
| Date: | 2022-12-22 07:18:45 |
| Message-ID: | TYAPR01MB58662090E3858FBD84226F6CF5E89@TYAPR01MB5866.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Dear Amit,
Thank you for updating the patch. I have also checked the patch
and basically it has worked well. Almost all things I found were modified
by v4.
One comment: while setting logical_decoding_mode to wrong value,
I got unfriendly ERROR message.
```
postgres=# SET logical_decoding_mode = 1;
ERROR: invalid value for parameter "logical_decoding_mode": "1"
HINT: Available values: , immediate
```
Here all acceptable enum should be output as HINT, but we could not see the empty string.
Should we modify config_enum_get_options() for treating empty string, maybe
like (empty)? Or we can ignore now.
Best Regards,
Hayato Kuroda
FUJITSU LIMITED
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kyotaro Horiguchi | 2022-12-22 07:45:07 | Re: Force streaming every change in logical decoding |
| Previous Message | Masahiko Sawada | 2022-12-22 07:16:32 | Re: Force streaming every change in logical decoding |