Fix one hint message in 002_pg_upgrade.pl

From: "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>
To: PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Fix one hint message in 002_pg_upgrade.pl
Date: 2023-10-18 07:27:45
Message-ID: TYAPR01MB5724A40D47E71F4717357EC694D5A@TYAPR01MB5724.jpnprd01.prod.outlook.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

There is one hint message in 002_pg_upgrade.pl that is not consistent with the
testing purpose.

# --check command works here, cleans up pg_upgrade_output.d.
command_ok(
[
'pg_upgrade', '--no-sync', '-d', $oldnode->data_dir,
...
ok(!-d $newnode->data_dir . "/pg_upgrade_output.d",
- "pg_upgrade_output.d/ not removed after pg_upgrade --check success");
+ "pg_upgrade_output.d/ removed after pg_upgrade --check success");

The test is to confirm the output file has been removed for pg_upgrade --check while
the message here is not consistent. Attach a small patch to fix it.

Best Regards,
Hou Zhijie

Attachment Content-Type Size
0001-Fix-one-hint-message-in-002_pg_upgrade.pl.patch application/octet-stream 903 bytes

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Magnus Hagander 2023-10-18 07:56:38 Re: run pgindent on a regular basis / scripted manner
Previous Message Peter Eisentraut 2023-10-18 07:20:55 Re: run pgindent on a regular basis / scripted manner