| From: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
|---|---|
| To: | 'Michael Paquier' <michael(at)paquier(dot)xyz> |
| Cc: | Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | RE: Rework subscription-related code for psql and pg_dump |
| Date: | 2024-11-29 05:42:13 |
| Message-ID: | TYAPR01MB5692DA54B241305BE3732BF8F52A2@TYAPR01MB5692.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Dear Michael,
Thanks for working on this.
It was not good to follow existing codes without confirmation :-(.
I grepped files in bin/ and could not find lines which includes catalog/pg_xxx.h files.
(One exception is pg_control.h. It is not a catalog-header but has the same prefix.)
The patch basically LGTM.
One comment...
In describeSubscriptions(), only the streaming option is represented as {off, on, parallel},
whereas twophase option is {d, p, e}.
I feel it is bit strange so we can fix to show like {disabled, pending, enabled} by the same approach.
Thought?
Best regards,
Hayato Kuroda
FUJITSU LIMITED
| From | Date | Subject | |
|---|---|---|---|
| Next Message | songjinzhou | 2024-11-29 05:50:24 | Re: Added prosupport function for estimating numeric generate_series rows |
| Previous Message | Zharkov Roman | 2024-11-29 05:39:52 | Re: plperl version on the meson setup summary screen |