RE: Found issues related with logical replication and 2PC

Dear Amit,

> Can we start a separate thread to issue 2? I understand that this one
> is also related to two_phase but since both are different issues it is
> better to discuss in separate threads. This will also help us refer to
> the discussion in future if required.

You are right, we should discuss one topic per thread. Forked: [1].

> BTW, why did the 0002 patch change the below code:
> --- a/src/include/replication/worker_internal.h
> +++ b/src/include/replication/worker_internal.h
> @@ -164,7 +164,8 @@ typedef struct ParallelApplyWorkerShared
>
> /*
> * XactLastCommitEnd or XactLastPrepareEnd from the parallel apply worker.
> - * This is required by the leader worker so it can update the lsn_mappings.
> + * This is required by the leader worker so it can update the
> + * lsn_mappings.
> */
> XLogRecPtr last_commit_end;
>

Opps. Fixed version is posted in [1].

[1]: https://www.postgresql.org/message-id/TYAPR01MB5692FAC23BE40C69DA8ED4AFF5B92%40TYAPR01MB5692.jpnprd01.prod.outlook.com

Best regards,
Hayato Kuroda
FUJITSU LIMITED