| From: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
|---|---|
| To: | 'Nisha Moond' <nisha(dot)moond412(at)gmail(dot)com> |
| Cc: | shveta malik <shveta(dot)malik(at)gmail(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Ajin Cherian <itsajin(at)gmail(dot)com>, Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Nathan Bossart <nathandbossart(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | RE: Introduce XID age and inactive timeout based replication slot invalidation |
| Date: | 2024-12-03 07:39:13 |
| Message-ID: | TYAPR01MB5692B7687EE7981AA91BA5B9F5362@TYAPR01MB5692.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Dear Nisha,
Thanks for updating the patch!
> Fixed. It is reasonable to align with other timeout parameters by
> using milliseconds as the unit.
It looks you just replaced to GUC_UNIT_MS, but the documentation and
postgresql.conf.sample has not been changed yet. They should follow codes.
Anyway, here are other comments, mostly cosmetic.
01. slot.c
```
+int replication_slot_inactive_timeout_ms = 0;
```
According to other lines, we should add a short comment for the GUC.
02. 050_invalidate_slots.pl
Do you have a reason why you use the number 050? I feel it can be 043.
03. 050_invalidate_slots.pl
Also, not sure the file name is correct. This file contains only a slot invalidation due to the
replication_slot_inactive_timeout. But I feel current name is too general.
04. 050_invalidate_slots.pl
```
+use Time::HiRes qw(usleep);
```
This line is not needed because usleep() is not used in this file.
Best regards,
Hayato Kuroda
FUJITSU LIMITED
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2024-12-03 07:49:41 | Re: Memory leak in WAL sender with pgoutput (v10~) |
| Previous Message | Shlok Kyal | 2024-12-03 07:01:38 | Re: Disallow UPDATE/DELETE on table with unpublished generated column as REPLICA IDENTITY |