| From: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
|---|---|
| To: | 'Tomas Vondra' <tomas(at)vondra(dot)me> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | RE: Fix for pageinspect bug in PG 17 |
| Date: | 2024-11-14 02:56:45 |
| Message-ID: | TYAPR01MB5692A621179C18A8FDB3AE60F55B2@TYAPR01MB5692.jpnprd01.prod.outlook.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Dear Tomas,
Thanks for updating the patch.
I've tested new patch and confirmed the brin_pgage_items() could error out:
```
postgres=# SELECT * FROM brin_page_items(get_raw_page('foo_id_idx', 2), 'foo_id_idx');
ERROR: function has wrong number of declared columns
HINT: To resolve the problem, update the "pageinspect" extension to the latest version.
```
I also do not have strong opinions for both approaches.
If I had to say... it's OK to do error out. The source becomes simpler and I cannot
find use-case that user strongly wants to use the older pageinspect extension.
Best regards,
Hayato Kuroda
FUJITSU LIMITED
| From | Date | Subject | |
|---|---|---|---|
| Next Message | vignesh C | 2024-11-14 03:44:40 | Re: Introduce XID age and inactive timeout based replication slot invalidation |
| Previous Message | Zhijie Hou (Fujitsu) | 2024-11-14 02:54:29 | RE: Conflict detection for update_deleted in logical replication |