| From: | "Fujii(dot)Yuki(at)df(dot)MitsubishiElectric(dot)co(dot)jp" <Fujii(dot)Yuki(at)df(dot)MitsubishiElectric(dot)co(dot)jp> |
|---|---|
| To: | Tender Wang <tndrwang(at)gmail(dot)com>, Tomasz Rybak <tomasz(dot)rybak(at)post(dot)pl> |
| Cc: | "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, "robertmhaas(at)gmail(dot)com" <robertmhaas(at)gmail(dot)com>, Richard Guo <guofenglinux(at)gmail(dot)com>, David Rowley <dgrowleyml(at)gmail(dot)com>, "Fujii(dot)Yuki(at)df(dot)MitsubishiElectric(dot)co(dot)jp" <Fujii(dot)Yuki(at)df(dot)MitsubishiElectric(dot)co(dot)jp> |
| Subject: | RE: Should consider materializing the cheapest inner path in consider_parallel_nestloop() |
| Date: | 2024-06-05 01:26:30 |
| Message-ID: | TYAPR01MB30884712D2366CF5F693529095F92@TYAPR01MB3088.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi. Tender.
Thank you for modification.
> From: Tender Wang <tndrwang(at)gmail(dot)com>
> Sent: Tuesday, June 4, 2024 7:51 PM
> Please add more tests. Especially please add some negative tests;
> current patch checks that it is safe to apply materialization. It would
> be helpful to add tests checking that materialization is not applied
> in both checked cases:
> 1. when inner join path is not parallel safe
> 2. when matpath is not parallel safe
>
>
>
> I added a test case that inner rel is not parallel safe. Actually,
> matpath will not create if inner rel is not parallel safe. So I didn't add test case for the second scenario.
Is there case in which matpath is not parallel safe and inner rel is parallel safe?
If right, I think that it would be suitable to add a negative test in a such case.
Sincerely yours,
Yuuki Fujii
--
Yuuki Fujii
Information Technology R&D Center Mitsubishi Electric Corporation
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2024-06-05 01:35:46 | Re: Partial aggregates pushdown |
| Previous Message | Ajin Cherian | 2024-06-05 01:24:45 | Re: Proposal: Filter irrelevant change before reassemble transactions during logical decoding |