RE: pgsql: Add a new GUC and a reloption to enable inserts in parallel-mode

From: "tsunakawa(dot)takay(at)fujitsu(dot)com" <tsunakawa(dot)takay(at)fujitsu(dot)com>
To: 'Robert Haas' <robertmhaas(at)gmail(dot)com>
Cc: Andres Freund <andres(at)anarazel(dot)de>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Amit Kapila <akapila(at)postgresql(dot)org>, pgsql-committers <pgsql-committers(at)lists(dot)postgresql(dot)org>
Subject: RE: pgsql: Add a new GUC and a reloption to enable inserts in parallel-mode
Date: 2021-03-25 01:25:28
Message-ID: TYAPR01MB299096757A1C2C6E265E50BDFE629@TYAPR01MB2990.jpnprd01.prod.outlook.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

From: Robert Haas <robertmhaas(at)gmail(dot)com>
> The amount of code isn't the issue. I'd rather expend a little more
> code and solve the problem in a better way.

Reading your reply to Andres-san, I feel sympathy about your attitude. Maybe we should outline the (rough) design first, discuss/guess its complexity, and ask for opinions on whether it's worth expending our effort for the complexity or choose an easier hack, considering the assumed use case and ensuring future extensibility not to prevent smooth enhancements.

With that said, I think the easy hack this time is good, because parallel INSERT/UPDATE/DELETE will only be used infrequently (compared to short OLTP transactions) for data migration and batch processing where the source data is ample. I don't think of a use case yet where we want to make parallel workers allocate an XID when only necessary.

> I did not mean to give offense, but I also don't think grotty is a
> strong word. I consider it a pretty mild word.

Thank you for telling me the impression of the word. TBH, I knew the word for the first time, and looked it up in English-Japanese dictionary. It didn't give good impression, and grotty sounds somewhat similar to grotesque, so I got worried "Robert-san may be angry."

Regards
Takayuki Tsunakawa

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Fujii Masao 2021-03-25 01:42:23 pgsql: Improve connection denied error message during recovery.
Previous Message Andrew Dunstan 2021-03-24 23:07:16 pgsql: Allow for installation-aware instances of PostgresNode