| From: | "tsunakawa(dot)takay(at)fujitsu(dot)com" <tsunakawa(dot)takay(at)fujitsu(dot)com> |
|---|---|
| To: | 'Amit Langote' <amitlangote09(at)gmail(dot)com>, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com> |
| Cc: | Zhihong Yu <zyu(at)yugabyte(dot)com>, "Andrey V(dot) Lepikhov" <a(dot)lepikhov(at)postgrespro(dot)ru>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | RE: POC: postgres_fdw insert batching |
| Date: | 2021-02-05 04:11:52 |
| Message-ID: | TYAPR01MB2990736EF4BF4FEB723BCE54FEB29@TYAPR01MB2990.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
From: Amit Langote <amitlangote09(at)gmail(dot)com>
> It appears I had missed your reply, sorry.
>
> > + PgFdwModifyState *fmstate = resultRelInfo->ri_FdwState ?
> > +
> (PgFdwModifyState *) resultRelInfo->ri_FdwState :
> > + NULL;
> >
> > This can be written as:
> >
> > + PgFdwModifyState *fmstate = (PgFdwModifyState *)
> > + resultRelInfo->ri_FdwState;
>
> Facepalm, yes.
>
> Patch updated. Thanks for the review.
Thank you for picking this up.
Regards
Takayuki Tsunakawa
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Smith | 2021-02-05 04:16:12 | Re: pg_replication_origin_drop API potential race condition |
| Previous Message | Hou, Zhijie | 2021-02-05 03:58:24 | RE: Parallel INSERT (INTO ... SELECT ...) |