| From: | "tsunakawa(dot)takay(at)fujitsu(dot)com" <tsunakawa(dot)takay(at)fujitsu(dot)com> |
|---|---|
| To: | 'Tomas Vondra' <tomas(dot)vondra(at)enterprisedb(dot)com> |
| Cc: | 'Amit Langote' <amitlangote09(at)gmail(dot)com>, "Andrey V(dot) Lepikhov" <a(dot)lepikhov(at)postgrespro(dot)ru>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | RE: POC: postgres_fdw insert batching |
| Date: | 2021-01-19 01:28:44 |
| Message-ID: | TYAPR01MB299026DB0E91E513664C162FFEA30@TYAPR01MB2990.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
From: Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>
> I took a look at this - there's a bit of bitrot due to 708d165ddb92c, so attached is
> a rebased patch (0001) fixing that.
>
> 0002 adds a couple comments and minor tweaks
>
> 0003 addresses a couple shortcomings related to explain - we haven't been
> showing the batch size for EXPLAIN (VERBOSE), because there'd be no
> FdwState, so this tries to fix that. Furthermore, there were no tests for EXPLAIN
> output with batch size, so I added a couple.
Thank you, good additions. They all look good.
Only one point: I think the code for retrieving batch_size in create_foreign_modify() can be replaced with a call to the new function in 0003.
God bless us.
Regards
Takayuki Tsunakawa
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2021-01-19 01:52:46 | Paint some PG_USED_FOR_ASSERTS_ONLY in inline functions of ilist.h and bufpage.h |
| Previous Message | Peter Smith | 2021-01-19 01:22:45 | pgindent for worker.c |