RE: psql - factor out echo code

From: <Shinya11(dot)Kato(at)nttdata(dot)com>
To: <coelho(at)cri(dot)ensmp(dot)fr>, <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: RE: psql - factor out echo code
Date: 2021-06-14 03:54:30
Message-ID: TYAPR01MB28962C85C5F2ECD7EF95BC7EC4319@TYAPR01MB2896.jpnprd01.prod.outlook.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

>-----Original Message-----
>From: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
>Sent: Sunday, May 30, 2021 6:10 PM
>To: PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
>Subject: psql - factor out echo code
>
>
>While working on something in "psql/common.c" I noticed some triplicated code,
>including a long translatable string. This minor patch refactors this in one
>function.
>
>--
>Fabien.

Wouldn't it be better to comment it like any other function?

Best regards,
Shinya Kato

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Dilip Kumar 2021-06-14 04:14:01 Re: Decoding speculative insert with toast leaks memory
Previous Message Amit Kapila 2021-06-14 03:04:23 Re: Decoding speculative insert with toast leaks memory