| From: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
|---|---|
| To: | "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Cc: | Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Peter Eisentraut <peter(at)eisentraut(dot)org>, Andres Freund <andres(at)anarazel(dot)de>, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, Euler Taveira <euler(at)eulerto(dot)com>, 'Amit Kapila' <amit(dot)kapila16(at)gmail(dot)com> |
| Subject: | RE: speed up a logical replica setup |
| Date: | 2024-01-11 12:18:01 |
| Message-ID: | TY3PR01MB98895BA6C1D72CB8582CACC4F5682@TY3PR01MB9889.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Dear hackers,
I have been concerned that the patch has not been tested by cfbot due to the
application error. Also, some comments were raised. Therefore, I created a patch
to move forward.
I also tried to address some comments which is not so claimed by others.
They were included in 0003 patch.
* 0001 patch
It is almost the same as v3-0001, which was posted by Euler.
An unnecessary change for Mkvcbuild.pm (this file was removed) was ignored.
* 0002 patch
This contains small fixes to keep complier quiet.
* 0003 patch
This addresses comments posted to -hackers. For now, this does not contain a doc.
Will add if everyone agrees these idea.
1.
An option --port was added to control the port number for physical standby.
Users can specify a port number via the option, or an environment variable PGSUBPORT.
If not specified, a fixed value (50111) would be used.
SOURCE: [1]
2.
A FATAL error would be raised if --subscriber-conninfo specifies non-local server.
SOURCE: [2]
3.
Options -o/-O were added to specify options for publications/subscriptions.
SOURCE: [2]
4.
Made standby to save their output to log file.
SOURCE: [2]
5.
Unnecessary Assert in drop_replication_slot() was removed.
SOURCE: [3]
How do you think?
Thanks Shlok and Vignesh to work with me offline.
[1]: https://www.postgresql.org/message-id/TY3PR01MB988978C7362A101927070D29F56A2%40TY3PR01MB9889.jpnprd01.prod.outlook.com
[2]: https://www.postgresql.org/message-id/TY3PR01MB9889593399165B9A04106741F5662%40TY3PR01MB9889.jpnprd01.prod.outlook.com
[3]: https://www.postgresql.org/message-id/CALDaNm098Jkbh%2Bye6zMj9Ro9j1bBe6FfPV80BFbs1%3DpUuTJ07g%40mail.gmail.com
Best Regards,
Hayato Kuroda
FUJITSU LIMITED
| Attachment | Content-Type | Size |
|---|---|---|
| v4-0001-Creates-a-new-logical-replica-from-a-standby-serv.patch | application/octet-stream | 62.6 KB |
| v4-0002-Fixed-small-bugs-to-keep-compiler-quiet.patch | application/octet-stream | 2.3 KB |
| v4-0003-Address-some-comments-proposed-on-hackers.patch | application/octet-stream | 8.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nazir Bilal Yavuz | 2024-01-11 12:21:27 | Re: make pg_ctl more friendly |
| Previous Message | Alvaro Herrera | 2024-01-11 12:04:18 | Re: A recent message added to pg_upgade |