RE: Partial aggregates pushdown

From: "Fujii(dot)Yuki(at)df(dot)MitsubishiElectric(dot)co(dot)jp" <Fujii(dot)Yuki(at)df(dot)MitsubishiElectric(dot)co(dot)jp>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Jelte Fennema-Nio <postgres(at)jeltef(dot)nl>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Stephen Frost <sfrost(at)snowman(dot)net>, Andres Freund <andres(at)anarazel(dot)de>, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, Julien Rouhaud <rjuju123(at)gmail(dot)com>, Daniel Gustafsson <daniel(at)yesql(dot)se>, vignesh C <vignesh21(at)gmail(dot)com>, Alexander Pyhalov <a(dot)pyhalov(at)postgrespro(dot)ru>, "Fujii(dot)Yuki(at)df(dot)MitsubishiElectric(dot)co(dot)jp" <Fujii(dot)Yuki(at)df(dot)MitsubishiElectric(dot)co(dot)jp>
Subject: RE: Partial aggregates pushdown
Date: 2024-07-07 21:52:27
Message-ID: TY2PR01MB3835F90801CE766B89B255EA95D92@TY2PR01MB3835.jpnprd01.prod.outlook.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Bruce.

> From: Bruce Momjian <bruce(at)momjian(dot)us>
> Is there a reason the documentation is no longer a part of this patch?
> Can I help you keep it current?

Here are the reasons:
Reason1. The approach differs significantly from the previous patch that included documentation, the below.
https://www.postgresql.org/message-id/attachment/152086/0001-Partial-aggregates-push-down-v34.patch
Reason2. I have two options for transmitting the state value and I'm evaluating which one is optimal.
One is what I presented you in PGConf.dev2024. The other is Jelte's one.
He listened to my talk at the conference and gave me some useful comments on hackers. I'm very grateful that.
Reason3. The implementation and test have been not finished yet.
Regarding Reason 2, I provided my conclusion in the previous message.

My plan for advancing the patch involves the following steps:
Step1. Decide the approach on transmitting state value.
Step2. Implement code (including comments) and tests to support a subset of aggregate functions.
Specifically, I plan to support avg, sum, and other aggregate functions like min and max which don't need export/import functions.
Step3. Add documentations.

To clarify my approach, should I proceed with Step 3 before Step2?
I would appreciate your feedback on this.

Best regards, Yuki Fujii
--
Yuki Fujii
Information Technology R&D Center, Mitsubishi Electric Corporation

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2024-07-07 23:14:20 Re: Pluggable cumulative statistics
Previous Message Fujii.Yuki@df.MitsubishiElectric.co.jp 2024-07-07 21:46:31 RE: Partial aggregates pushdown