Re: cvs head initdb hangs on unixware

On Wed, 10 Dec 2008, Heikki Linnakangas wrote:

> Date: Wed, 10 Dec 2008 13:00:31 +0200
> From: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
> To: ohp(at)pyrenet(dot)fr
> Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM>,
> pgsql-hackers list <pgsql-hackers(at)postgresql(dot)org>
> Subject: Re: [HACKERS] cvs head initdb hangs on unixware
>
> ohp(at)pyrenet(dot)fr wrote:
>> On Tue, 9 Dec 2008, Tom Lane wrote:
>>> Hmm. It looks to me like the compiler is getting confused by the
>>> interaction between nodeno, leftnodeno, and rightnodeno. Try this
>>> patch to see if it gets around it. (This is a tad better anyway
>>> since it avoids examining the right child if not needed.)
>>>
>> Brillant!
>> You made my day, can't wait for this patch to be committed.
>
> I find it pretty scary to work around compiler bugs like this. Who knows what
> other code it miscompiles. Can you reduce fsm_search_avail into a small
> stand-alone test program, and file a bug report with the compiler vendor?
FWIW, the compiler doesn't miscompîle anything on postgresql, as an heavy
user/hoster, I'd know!

Let's not start a flame here, SCO compiler is as good or as bad as
anyother..

Never saw a problem with gcc, hp-ux, darwin or M$?
>
> BTW, why does this work on warthog buildfarm member? Different compiler
> version?
>
it's configured with --enable-debug.
Maybe run_build.pl should run twice, onece with --enable-debug once
without.
>

--
Olivier PRENANT Tel: +33-5-61-50-97-00 (Work)
15, Chemin des Monges +33-5-61-50-97-01 (Fax)
31190 AUTERIVE +33-6-07-63-80-64 (GSM)
FRANCE Email: ohp(at)pyrenet(dot)fr
------------------------------------------------------------------------------
Make your life a dream, make your dream a reality. (St Exupery)
>From pgsql-hackers-owner(at)postgresql(dot)org Wed Dec 10 10:06:07 2008
Received: from localhost (unknown [200.46.204.183])
by mail.postgresql.org (Postfix) with ESMTP id AB28464FFE8
for <pgsql-hackers-postgresql(dot)org(at)mail(dot)postgresql(dot)org>; Wed, 10 Dec 2008 10:06:06 -0400 (AST)
Received: from mail.postgresql.org ([200.46.204.86])
by localhost (mx1.hub.org [200.46.204.183]) (amavisd-maia, port 10024)
with ESMTP id 34846-07
for <pgsql-hackers-postgresql(dot)org(at)mail(dot)postgresql(dot)org>;
Wed, 10 Dec 2008 10:05:56 -0400 (AST)
X-Greylist: from auto-whitelisted by SQLgrey-1.7.6
Received: from lists.commandprompt.com (host-159.commandprompt.net [207.173.203.159])
by mail.postgresql.org (Postfix) with ESMTP id F0B8F64FEB3
for <pgsql-hackers(at)postgresql(dot)org>; Wed, 10 Dec 2008 10:05:55 -0400 (AST)
Received: from perhan.alvh.no-ip.org (200-126-68-73.bk5-dsl.surnet.cl [200.126.68.73])
(authenticated bits=0)
by lists.commandprompt.com (8.13.8/8.13.8) with ESMTP id mBAEAOmJ031897
(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
Wed, 10 Dec 2008 06:10:27 -0800
Received: by perhan.alvh.no-ip.org (Postfix, from userid 1000)
id 0F8C847CCD; Wed, 10 Dec 2008 11:05:23 -0300 (CLST)
Date: Wed, 10 Dec 2008 11:05:23 -0300
From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Merlin Moncure <mmoncure(at)gmail(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>,
dmitry(at)koterov(dot)ru, pgsql-hackers(at)postgresql(dot)org
Subject: Re: ALTER composite type does not work, but ALTER TABLE
which ROWTYPE is used as a type - works fine
Message-ID: <20081210140522(dot)GB5503(at)alvh(dot)no-ip(dot)org>
References: <603c8f070812080649y29f8946fref9f46a7232a8489(at)mail(dot)gmail(dot)com> <200812101136(dot)mBABaO805042(at)momjian(dot)us> <603c8f070812100444i4bf1d416se0dccbf2c02ba724(at)mail(dot)gmail(dot)com> <b42b73150812100459s21ff5284s92e3077485111468(at)mail(dot)gmail(dot)com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <b42b73150812100459s21ff5284s92e3077485111468(at)mail(dot)gmail(dot)com>
User-Agent: Mutt/1.5.18 (2008-05-17)
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0 (lists.commandprompt.com [207.173.203.159]); Wed, 10 Dec 2008 06:10:28 -0800 (PST)
X-Virus-Scanned: Maia Mailguard 1.0.1
X-Spam-Status: No, hits=0 tagged_above=0 required=5 tests=none
X-Spam-Level:
X-Archive-Number: 200812/640
X-Sequence-Number: 129269

Merlin Moncure escribió:
> >> Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
> >> OK, so what should the TODO item be?
> On Wed, Dec 10, 2008 at 7:44 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> > Allow ALTER TYPE to add, rename, change the type of, and drop columns?
>
> That's probably the consensus view. Personally, I think creating
> composite types through 'create type as' was a mistake...we probably
> should have gone through create table instead with some special syntax
> for storage-less tables aka composite types.

I disagree that CREATE TABLE should be (or should have been) used to
create types. Someday we might need to expand the work we do for that
case in a different direction than tables, and we would be stuck.

Also, for tables we create files, we generate statistics, we compute
relfrozenxid, we call vacuum on, and so on and so forth. We do none of
these things on types.

In fact, types are not in pg_class at all.

--
Alvaro Herrera http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support