Re: BUG #2948: default null values for not-null domains

From: Sergiy Vyshnevetskiy <serg(at)vostok(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-bugs(at)postgresql(dot)org
Subject: Re: BUG #2948: default null values for not-null domains
Date: 2007-02-01 18:10:02
Message-ID: Pine.LNX.4.64.0702011939280.22446@uanet.vostok.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

On Thu, 1 Feb 2007, Tom Lane wrote:

> Sergiy Vyshnevetskiy <serg(at)vostok(dot)net> writes:
>> Why not add PLPGSQL_TTYPE_DOMAIN and rename PLPGSQL_TTYPE_SCALAR to
>> PLPGSQL_TTYPE_BASE? We only use PLPGSQL_TTYPE_SCALAR in _3_ places!
>
> That was my first thought too, but it's wrong. The right thing is to
> look at the strictness of the input function, because that is the API
> we have defined to determine whether a datatype might possibly be
> interested in rejecting nulls. The fact that domain_in() is the only
> example in the core system doesn't make it correct to restrict the
> functionality to domains.

...
I have been slow.
If input function IS strict then nulls are ALWAYS accepted.
If input function IS NOT strict then nulls MIGHT be rejectted.

And the patch is much more simple now (attached).
Is that it?

Attachment Content-Type Size
patch-pl_exec.c text/x-csrc 494 bytes

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Tom Lane 2007-02-01 19:28:14 Re: BUG #2948: default null values for not-null domains
Previous Message Tom Lane 2007-02-01 17:35:15 Re: BUG #2948: default null values for not-null domains