Re: tsearch in core patch, for inclusion

From: Oleg Bartunov <oleg(at)sai(dot)msu(dot)su>
To: nikolay(at)samokhvalov(dot)com
Cc: Teodor Sigaev <teodor(at)sigaev(dot)ru>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: tsearch in core patch, for inclusion
Date: 2007-01-25 17:51:14
Message-ID: Pine.LNX.4.64.0701252048450.400@sn.sai.msu.ru
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

On Thu, 25 Jan 2007, Nikolay Samokhvalov wrote:

> On 1/25/07, Teodor Sigaev <teodor(at)sigaev(dot)ru> wrote:
>> It's should clear enough for now - dump data from old db and load into new
>> one.
>> But dump should be without any contrib/tsearch2 related functions.
>
> Upgrading from 8.1.x to 8.2.x was not tivial because of very trivial
> change in API (actually not really API but the content of "pg_ts_*"
> tables): russian snowball stemming function was forked to 2 different
> ones, for koi8 and utf8 encodings. So, as I dumped my pg_ts_* tables
> data (to keep my tsearch2 settings), I saw errors during restoration
> (btw, why didn't you keep old russian stemmer function name as a
> synonym to koi8 variant?) -- so, I had to change my dump file
> manually, because I didn't manage to follow "tsearch2 best practices"

sed and grep did the trick.

> (to use some kind of "bootstrap" script that creates tsearch2
> configuration you need from default one -- using several INSERTs and
> UPDATEs). And there were no upgrade notes for tsearch2.

This is unfair, you promised to write upgrade notes and we discussed the
problem with name change before release and I rely on you. It was my fault,
of course.

Regards,
Oleg
_____________________________________________________________
Oleg Bartunov, Research Scientist, Head of AstroNet (www.astronet.ru)
Sternberg Astronomical Institute, Moscow University, Russia
Internet: oleg(at)sai(dot)msu(dot)su, http://www.sai.msu.su/~megera/
phone: +007(495)939-16-83, +007(495)939-23-83

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2007-01-25 17:58:13 Re: crash on 8.2 and cvshead - failed to add item to the
Previous Message Joshua D. Drake 2007-01-25 17:46:37 Re: Proposal: allow installation of any contrib module

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2007-01-25 18:26:50 Re: guid/uuid datatype
Previous Message Joshua D. Drake 2007-01-25 17:27:04 Re: guid/uuid datatype