Re: BUG #1970: Existing /etc/pam.d/postgresql clobbered by

Hi,

On Mon, 17 Oct 2005, Mark Gibson wrote:

> Bug reference: 1970
> Logged by: Mark Gibson
> Email address: gibsonm(at)cromwell(dot)co(dot)uk
> PostgreSQL version: 8.0.4
> Operating system: Redhat Enterprise Linux 4
> Description: Existing /etc/pam.d/postgresql clobbered by RPM install
> Details:
>
> Hello, I noticed that when installing the 8.0.4 RPM's
> it replaced our existing /etc/pam.d/postgresql - this caused our system to
> break temporarily, as it was missing the following line:
>
> account required pam_stack.so service=system-auth
>
> I don't know whether this is required for all systems or is just a
> peculiarity of our setup, but could the RPM be changed to not clobber this
> file in the future. I believe some RPM's install conflicting configs with
> the .rpmnew extension. Cheers.

AFAIK, RPMs look for RPM database for the existing files on the system. I
think your file was not generated by any RPM, so our RPM wanted to
replace it.

I can't see any problems with adding

account required pam_stack.so service=system-auth

to our postgresql.pam file. If noone objects, we may release a new
subversion of 8.0.4 with this fix (and elog patch of Tom).

Regards,
--
Devrim GUNDUZ
Kivi Bilişim Teknolojileri - http://www.kivi.com.tr
devrim~gunduz.org, devrim~PostgreSQL.org, devrim.gunduz~linux.org.tr
http://www.gunduz.org
>From pgsql-bugs-owner(at)postgresql(dot)org Tue Oct 18 19:34:04 2005
X-Original-To: pgsql-bugs-postgresql(dot)org(at)localhost(dot)postgresql(dot)org
Received: from localhost (av.hub.org [200.46.204.144])
by svr1.postgresql.org (Postfix) with ESMTP id AB82FD999F;
Tue, 18 Oct 2005 19:01:44 -0300 (ADT)
Received: from svr1.postgresql.org ([200.46.204.71])
by localhost (av.hub.org [200.46.204.144]) (amavisd-new, port 10024)
with ESMTP id 48026-07; Tue, 18 Oct 2005 22:01:41 +0000 (GMT)
Received: from sss.pgh.pa.us (sss.pgh.pa.us [66.207.139.130])
by svr1.postgresql.org (Postfix) with ESMTP id 9DFF6D99BF;
Tue, 18 Oct 2005 19:01:42 -0300 (ADT)
Received: from sss2.sss.pgh.pa.us (tgl(at)localhost [127.0.0.1])
by sss.pgh.pa.us (8.13.1/8.13.1) with ESMTP id j9IM1dA6014247;
Tue, 18 Oct 2005 18:01:39 -0400 (EDT)
To: Devrim GUNDUZ <devrim(at)gunduz(dot)org>
Cc: Mark Gibson <gibsonm(at)cromwell(dot)co(dot)uk>, pgsql-bugs(at)postgresql(dot)org,
pgsqlrpms-hackers(at)postgresql(dot)org
Subject: Re: BUG #1970: Existing /etc/pam.d/postgresql clobbered by
In-reply-to: <Pine(dot)LNX(dot)4(dot)63(dot)0510181637130(dot)9125(at)mail(dot)kivi(dot)com(dot)tr>
References: <20051017074717(dot)338B4F0D79(at)svr2(dot)postgresql(dot)org> <Pine(dot)LNX(dot)4(dot)63(dot)0510181637130(dot)9125(at)mail(dot)kivi(dot)com(dot)tr>
Comments: In-reply-to Devrim GUNDUZ <devrim(at)gunduz(dot)org>
message dated "Tue, 18 Oct 2005 23:18:04 +0300"
Date: Tue, 18 Oct 2005 18:01:39 -0400
Message-ID: <14246(dot)1129672899(at)sss(dot)pgh(dot)pa(dot)us>
From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
X-Virus-Scanned: by amavisd-new at hub.org
X-Spam-Status: No, hits=0.006 required=5 tests=[AWL=0.006]
X-Spam-Level:
X-Archive-Number: 200510/220
X-Sequence-Number: 13201

Devrim GUNDUZ <devrim(at)gunduz(dot)org> writes:
> I can't see any problems with adding
> account required pam_stack.so service=system-auth

See also
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=167040
which is what inspired this to start with. Not knowing enough about
PAM, I didn't get it right the first time :-(

regards, tom lane