From: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
---|---|
To: | Thomas Hallgren <thhal(at)mailblocks(dot)com> |
Cc: | PostgreSQL Developers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Problems using pgxs on Win32 |
Date: | 2004-11-02 07:26:16 |
Message-ID: | Pine.LNX.4.61.0411020816530.13443@sablons.cri.ensmp.fr |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-patches |
Dear Thomas,
>>> ifdef PGXS
>>> override CPPFLAGS := -I$(includedir_server)
>>> -I$(includedir_server)/port/win32 -I$(includedir_internal) $(CPPFLAGS)
>>> else # not PGXS
>>
>> Why can't you #include "port/win32/some_file.h" which would (I think)
>> avoid the issue without adding a win32 specific -I to all architectures??
>> I'm not sure I'm happy if I see a win32 path when compiling under some
>> unix.
>>
> I'm not sure I understand. I'm not the one including the missing files. They
> are included when I include postgres.h.
Ok.
It seems that this directory provides fake header files to replace "unix"
system headers. Hence ISTM that no one wants this -I on any other
platform, so the possible inclusion must be added under some condition,
not just ifdef PGXS.
I'm wondering how it works within the source tree. I guess the
Makefile.port must/should take care of this issue, and maybe it is broken
under pgxs? I'll look into that, but I cannot test anything:-(
--
Fabien Coelho - coelho(at)cri(dot)ensmp(dot)fr
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Eisentraut | 2004-11-02 09:17:50 | Re: charset/collation in values |
Previous Message | Greg Stark | 2004-11-02 06:01:19 | Re: tablespaces for temporary files |
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Eisentraut | 2004-11-02 09:09:43 | Re: Translation updates: pt_BR |
Previous Message | Bruce Momjian | 2004-11-02 05:44:04 | Re: pthread.h header check |