Re: [PATCHES] Win32 CHECK_FOR_INTERRUPTS() performance tweak

From: Qingqing Zhou <zhouqq(at)cs(dot)toronto(dot)edu>
To: pgsql-hackers(at)postgresql(dot)org
Subject: Re: [PATCHES] Win32 CHECK_FOR_INTERRUPTS() performance tweak
Date: 2005-10-21 20:03:04
Message-ID: Pine.LNX.4.58.0510211602440.23248@josh.db
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, 21 Oct 2005, Magnus Hagander wrote:

> > > Shall we add "volatile" quanlifier to at least pg_signal_queue?
> >
> > If that's changed by a separate thread, "volatile" seems essential.
> > What about the mask variable?
>
> Yes, that does seem right. Previously it would never be concurrently
> modified, because it was always locked by the critical section, but now
> we read it without locking, and we certainly don't want that optimized
> away.
>
> The mask is only ever written by the main thread, never by the signal
> dispatching thread. So I think that one could do without.
>

Agreed.

Regards,
Qingqing

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2005-10-21 20:14:58 Re: [PATCHES] Win32 CHECK_FOR_INTERRUPTS() performance tweak
Previous Message Merlin Moncure 2005-10-21 19:30:50 Re: [PATCHES] Win32 CHECK_FOR_INTERRUPTS() performance tweak