Re: pgsql: Recognize ERROR_SHARING_VIOLATION (translate to EACCES),

From: Qingqing Zhou <zhouqq(at)cs(dot)toronto(dot)edu>
To: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Recognize ERROR_SHARING_VIOLATION (translate to EACCES),
Date: 2005-10-07 23:07:58
Message-ID: Pine.LNX.4.58.0510071906160.19651@eon.cs
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers


"Tom Lane" <tgl(at)svr1(dot)postgresql(dot)org> wrote
> Recognize ERROR_SHARING_VIOLATION (translate to EACCES), increase log
> level for unrecognized win32 error codes to LOG, and make messages
> conform to style guide.

This patch does not really work. This is because when mdread()/mdwrite()
fails, it does *not* call our own _dosmaperr() routine. Instead, it calls
the Win32 CRT's _dosmapperr() to do the translation (which fails to
translate ERROR_SHARING_VIOLATION either). If we want our _dosmaperr() to
play role in, we have to call it explicitely in mdread()/mdwrite() or
lower levels like FileRead()/FileWrite().

I would suggest don't revert this patch. When we get the feedback from
Jean-Pierre Pelletier, we can make the patch complete.

Regards,
Qingqing

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Qingqing Zhou 2005-10-08 02:07:01 Re: pgsql: Recognize ERROR_SHARING_VIOLATION (translate to EACCES), increase
Previous Message User Aglio 2005-10-07 22:07:49 press - pr: Extended the "licensing" paragraph to be more pointed.