Re: [HACKERS] Duplicate object names in GRANT

From: Gavin Sherry <swm(at)linuxworld(dot)com(dot)au>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org, pgsql-patches(at)postgresql(dot)org
Subject: Re: [HACKERS] Duplicate object names in GRANT
Date: 2005-07-28 06:00:24
Message-ID: Pine.LNX.4.58.0507281558130.1799@linuxworld.com.au
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

On Wed, 27 Jul 2005, Tom Lane wrote:

> Gavin Sherry <swm(at)linuxworld(dot)com(dot)au> writes:
> > I ran across this yesterday on HEAD:
>
> > template1=# grant select on foo, foo to swm;
> > ERROR: tuple already updated by self
>
> Seems to fail similarly in every version back to 7.2; probably further,
> but that's all I have running at the moment.
>
> > We could do away with the error by producing a unique list of object names
> > -- but that would impose an extra cost on the common case.
>
> CommandCounterIncrement in the GRANT loop would be easier, likely.
> I'm having a hard time getting excited about it though...

Yeah, its not that exciting but that error message would throw your
average user.

I've attached a patch which calls CommandCounterIncrement() in each of the
grant loops.

Thanks,

Gavin

Attachment Content-Type Size
grant.patch text/plain 1.4 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Simon Riggs 2005-07-28 06:21:13 Re: VACUUM DATABASE
Previous Message Neil Conway 2005-07-28 05:12:49 Re: Some new list.c primitives

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2005-07-28 06:34:59 Re: PLPGSQL OID Bug
Previous Message Neil Conway 2005-07-28 05:51:45 Re: PLPGSQL OID Bug