Re: Unit testing

From: Gavin Sherry <swm(at)linuxworld(dot)com(dot)au>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Neil Conway <neilc(at)samurai(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Unit testing
Date: 2004-10-12 00:55:47
Message-ID: Pine.LNX.4.58.0410121054250.25608@linuxworld.com.au
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, 11 Oct 2004, Tom Lane wrote:

> Neil Conway <neilc(at)samurai(dot)com> writes:
> > On Tue, 2004-10-12 at 00:43, Tom Lane wrote:
> >> Most likely (and I for one will for sure resist any attempt to force
> >> global uniqueness on static names).
>
> > You're right that the issue can be avoided easily enough, but what need
> > is there _not_ to have globally unique function names?
>
> To me that's pretty much in the you've-got-to-be-kidding domain. The
> reason static functions and local name scoping were invented was exactly
> to avoid having to ensure every single name is unique across a whole
> project. The overhead of avoiding duplicates swamps any possible
> benefit.

I agree. I think we can use #include foo.c and in any situation where we
*may* run into duplicate statics, a few lines of sed magic should be
enough. Thus, we would have no impact on the existing code.

Gavin

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Marc G. Fournier 2004-10-12 00:56:11 Re: CVS fixed ...
Previous Message Tom Lane 2004-10-12 00:51:07 Re: Unit testing