Re: [BUGS] BUG #1219: pgxs does not work fully

From: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
To: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
Cc: PostgreSQL Bugs List <pgsql-bugs(at)postgresql(dot)org>, PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [BUGS] BUG #1219: pgxs does not work fully
Date: 2004-08-17 12:26:35
Message-ID: Pine.LNX.4.58.0408171412300.30419@sablons.cri.ensmp.fr
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-patches


Please find enclose a submission to fix these problems.

The patch adds missing the "libpgport.a" file to the installation under
"install-all-headers". It is needed by some contribs. I install the
library in "pkglibdir", but I was wondering whether it should be "libdir"?
I was wondering also whether it would make sense to have a "libpgport.so"?

It fixes various macros which are used by contrib makefiles, especially
libpq_*dir and LDFLAGS when used under PGXS. It seems to me that they are
needed to

It adds the ability to test and use PGXS with contribs, with "make
USE_PGXS=1". Without the macro, this is exactly as before, there should be
no difference, esp. wrt the vpath feature that seemed broken by previous
submission. So it should not harm anybody, and it is useful at least to me.

It fixes some inconsistencies in various contrib makefiles
(useless override, ":=" instead of "=").

It works for me. it validates.

I'm available to fix any problem with this patch.

Have a nice day,

--
Fabien Coelho - coelho(at)cri(dot)ensmp(dot)fr

Attachment Content-Type Size
install_build_2.patch text/plain 39.9 KB

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message PostgreSQL Bugs List 2004-08-17 14:14:09 BUG #1220: "alter table rename to" inside a transaction violates ACID ordering
Previous Message Jheneffer Taruc 2004-08-17 07:58:49 error

Browse pgsql-patches by date

  From Date Subject
Next Message Mark Cave-Ayland 2004-08-17 14:33:49 Re: [PATCHES] GUC variables invisible to contrib/ modules
Previous Message Andreas Pflug 2004-08-17 10:40:58 Re: [PATCHES] libpq build problem with <io.h>