Re: Minor BEFORE DELETE trigger fix

From: Gavin Sherry <swm(at)linuxworld(dot)com(dot)au>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: Minor BEFORE DELETE trigger fix
Date: 2004-08-13 04:07:16
Message-ID: Pine.LNX.4.58.0408131403100.14105@linuxworld.com.au
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

On Thu, 12 Aug 2004, Bruce Momjian wrote:

>
> Did this get resolved?
>
> ---------------------------------------------------------------------------
>
> Gavin Sherry wrote:
> > Attached is a minor patch to make BEFORE DELETE triggers honour tgenabled
> > properly.
> >
> > I know that we cannot, currently, use this feature through a DDL command
> > but just in case someone is updating the catalogs to do it and since it is
> > necessary in order to implement disabling of triggers, I thought I'd send
> > it in.
> >
> > Gavin

After taking a proper look, I agree with Tom that my patch was not the
proper solution to the problem. What we really need for the BEFORE
ROW triggers is the ability to say that there were no triggers executeed.
At the moment, if no triggers are executed (ie, they're all disabled),
then the executor thinks that a trigger returned NULL.

I'll try to find some time to fix this soon. As I noted, though, its not
critical because there's no DDL to disable a trigger.

Gavin

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Christopher Kings-Lynne 2004-08-13 04:13:44 Re: [PATCHES] Patch for pg_dump: Multiple -t options and
Previous Message Oliver Jowett 2004-08-13 04:04:19 Re: Add GUC_REPORT to server_encoding, integer_datetimes