Re: Minor DROP TABLESPACE issue

From: Gavin Sherry <swm(at)linuxworld(dot)com(dot)au>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: Minor DROP TABLESPACE issue
Date: 2004-06-19 01:19:30
Message-ID: Pine.LNX.4.58.0406191115050.11419@linuxworld.com.au
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, 18 Jun 2004, Tom Lane wrote:

> Although DROP TABLESPACE can detect tables existing in the target
> tablespace, it doesn't have any way to detect schemas that reference
> that tablespace as their default tablespace. Thus you can get
> implementation-level failures like this one:
>

Of course. Never thought of that one.

> The fact that it fails isn't a big problem, but the error message is
> pretty unclear if you're unfamiliar with the implementation.
>
> The same problem would exist with respect to a database's default
> tablespace, except that a database will always have its system catalogs
> stored there and so the file-level check prevents dropping the
> tablespace.

Is it really that bad? NamespaceCreate() could just touch a file at
pg_tablespaces/<tablespaceoid>/<MyDatabaseId>/<namespace oid> and
RemoveSchema() could remove it.

Is there anything ugly that I've missed?

Gavin

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Scott Marlowe 2004-06-19 01:21:07 Re: email browser?
Previous Message Tom Lane 2004-06-19 01:10:09 Minor DROP TABLESPACE issue