Re: Tablespace patch review

On Fri, 18 Jun 2004, Tom Lane wrote:

> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > OK, I have reviewed the patch. I think Tom is doing the same, but I
> > want to report the things I found.
>
> I just came up for air after about two solid days of working on this
> patch ... had not seen your message before committing it. The good
> news is that I think I did see all the stuff you found.

Awesome.

>
> > What facility is there for moving objects between tablespaces?
>
> None, as yet.
>
> > Seems we should be consistent in having WIN32 defs or not.
>
> Probably. I removed #ifdefs whereever possible --- there are just a few
> left in tablespace.c and dbcommands.c now. I was contemplating
> replacing HAVE_SYMLINKS with a HAVE_TABLESPACES flag, but with the
> occurrences isolated to one file I'm not sure it's worth the trouble.
>
> > Your code in tablespc.c calls realpath(). Do all OS's have that?
>
> It doesn't anymore --- I was concerned about the portability question
> too. The only point of that code AFAICS was to prevent creation of
> two pg_tablespace entries pointing at the same directory. I felt that
> the better way to handle this was to write a PG_VERSION file in the
> tablespace directory during CREATE TABLESPACE. A subsequent CREATE
> TABLESPACE on the same directory will fail because the directory isn't
> empty anymore. And the version file might come in handy someday...

Yes. That's a better idea.

[snip]

> > Where do we need to add mention of tablespaces in the main
> > non-reference-page docs? Clearly at least in the section on managing
> > disk space.
>
> Yeah. The patch as committed covers the reference pages, but we
> desperately need a higher-level discussion of tablespaces for the
> administrator's guide.

I'll look at this tomorrow.

Thanks for your assistance.

>
> regards, tom lane
>

Gavin