Re: add server include files to default installation?

From: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: PostgreSQL Developers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: add server include files to default installation?
Date: 2004-05-17 11:48:54
Message-ID: Pine.LNX.4.58.0405171331500.19985@sablons.cri.ensmp.fr
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


Dear hackers,

> Agreed. I would also like to see Makefile.global installed.
> pg_config.h has C-level configs, and Makefile.global has the
> Makefile-level configs.

There is also "config.status" which is definitely of interest as it
allows to recreate the build tree, and which is not installed by default.

Independently of the actual file list to be included, where
could these makefiles be installed?

- share is for "architecture independent" files. Not really the case.

- include is rather for C files... but Makefile.global and others are
actually included, so it may make sense? If so, should it be directly
in the include/postgresql subdir, or some special subdir, say
"include/postgresql/config"?

- some other directory?

I would tend to put everything in "include/postgresql/config":
- Makefile.global
- a copy of Makefile.port (the actual file, not the link)
- config.status
- possibly other included files (NLS? win32? cygwin?)

Another issue is that Makefile.global seems hardwired to be in
the "src" subdirectory of a postgresql source tree, and to find other
files there:

# Pull in platform-specific magic
include $(top_builddir)/src/Makefile.port

This is an issue for external tools that would like to include
Makefile.global so as to be in the same environment as the server
compilation.

Any idea? The best I have would be to create a "src" subdir in the
installation, so that top_builddir could be set to
".../include/postgresql/config" and everything would work from that
point of view.

--
Fabien COELHO _ http://www.cri.ensmp.fr/~coelho _ Fabien(dot)Coelho(at)ensmp(dot)fr
CRI-ENSMP, 35, rue Saint-Honoré, 77305 Fontainebleau cedex, France
phone: (+33|0) 1 64 69 {voice: 48 52, fax: 47 09, standard: 47 08}
________ All opinions expressed here are mine _________

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2004-05-17 12:21:41 Re: Call for 7.5 feature completion
Previous Message Andrew Dunstan 2004-05-17 11:29:29 Re: enabling tcpip_socket by default