From: | Gavin Sherry <swm(at)linuxworld(dot)com(dot)au> |
---|---|
To: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Christopher Kings-Lynne <chriskl(at)familyhealth(dot)com(dot)au>, Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: pg_dump end comment |
Date: | 2004-03-30 08:20:08 |
Message-ID: | Pine.LNX.4.58.0403301818560.642@linuxworld.com.au |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-patches |
On Tue, 30 Mar 2004, Bruce Momjian wrote:
> Tom Lane wrote:
> > Christopher Kings-Lynne <chriskl(at)familyhealth(dot)com(dot)au> writes:
> > > This might seem a bit silly, but is there any chance we could add a
> > > comment at the end of pg_dump text output that says '-- End of dump'?
> >
> > Sure --- while you're at it, put a "beginning of dump" at the start.
> >
> > Is it worth adding the database name and/or other command-line
> > parameters given to pg_dump?
> >
> > One thing to think about is the difference between a bare pg_dump and a
> > pg_dump/pg_restore sequence. Should these always generate identical
> > text output? (They do as of CVS tip, I believe, though this was not
> > always true before.)
> >
> > Possibly this is all gilding the lily though...
>
> I like an end-of-dump marker for folks who want to check if the dump got
> truncated somehow. I can see how to do that for text dumps, but what
> about for tar or custom dumps?
Wouldn't it be more effective to test for non zero return status as this
handles -Fc cases, etc, which would be non-trivial to test.
Gavin
From | Date | Subject | |
---|---|---|---|
Next Message | Dennis Haney | 2004-03-30 13:06:21 | Hash cost |
Previous Message | Karel Zak | 2004-03-30 07:19:15 | Re: [HACKERS] Dates BC. |
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2004-03-30 14:13:10 | Re: pg_dump end comment |
Previous Message | Karel Zak | 2004-03-30 07:19:15 | Re: [HACKERS] Dates BC. |