Re: TODO item -- Improve psql's handling of multi-line

From: "Sergey E(dot) Koposov" <math(at)sai(dot)msu(dot)ru>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Andreas Seltenreich <seltenreich(at)gmx(dot)de>, Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, <pgsql-patches(at)postgresql(dot)org>
Subject: Re: TODO item -- Improve psql's handling of multi-line
Date: 2005-12-08 04:13:48
Message-ID: Pine.LNX.4.44.0512080703070.30096-200000@lnfm1.sai.msu.ru
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

On Wed, 7 Dec 2005, Andrew Dunstan wrote:

> Sergey E. Koposov wrote:
>
> >I also wanted this feature for a long time.
> >And I agree that it is rather simple to just remove the \n when writing to the
> >readline history file, but I don't think that's what everybody wants. I
> >think that people want to preserve the original formatting...
> >
> >So in that case the solution can be just putting some symbol instead of \n
> >in the history file, and during the loading of that file replace it back
> >(that symbol can be zero byte for example). But I'm not sure that people
> >will like that solution too.
> >
> A zero byte is probably a pretty bad choice. Some other low valued byte
> (e.g. \x01 ) would probably work better.
>
> And I agree that format preservation is highly desirable.

If actually the idea with just replacing '\n' in the history with other
byte is not rejected I'm
sending the new version of the psql patch including also the saving of the
multiline queries in the history (even after exiting the psql).
Currently I replace '\n' with the '\x01' as Andrew suggested.

Regards,

Sergey

*****************************************************
Sergey E. Koposov
Max-Planck Institut for Astronomy
Web: http://lnfm1.sai.msu.ru/~math
E-mail: math(at)sai(dot)msu(dot)ru

Attachment Content-Type Size
psql.patch text/plain 10.7 KB

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2005-12-08 06:34:54 Re: TODO item -- Improve psql's handling of multi-line
Previous Message Andrew Dunstan 2005-12-08 03:00:23 Re: TODO item -- Improve psql's handling of multi-line